Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

mmarkelov
Copy link
Member

close #214

@github-actions
Copy link

Pull Request Test Coverage Report for Build 166389286

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 92.254%

Files with Coverage Reduction New Missed Lines %
src/utils.ts 1 91.67%
Totals Coverage Status
Change from base Build 164555381: 0.1%
Covered Lines: 85
Relevant Lines: 90

💛 - Coveralls

@mmarkelov mmarkelov marked this pull request as ready for review July 12, 2020 12:50
@mmarkelov mmarkelov requested a review from mxschmitt as a code owner July 12, 2020 12:50
Copy link
Collaborator

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems hacky but if it works then itsfine

@mmarkelov
Copy link
Member Author

Seems hacky but if it works then itsfine

What exactly looks hacky? Maybe I can rewrite it in nicer way?
I decided to use process.env.npm_package_type cause I think that it is better than read whole package.json to checkout package type.

@mxschmitt
Copy link
Collaborator

Seems hacky but if it works then itsfine

What exactly looks hacky? Maybe I can rewrite it in nicer way?
I decided to use process.env.npm_package_type cause I think that it is better than read whole package.json to checkout package type.

to handle cjs, but never worked with cjs files. Lets land this change! 👍

@mmarkelov mmarkelov merged commit fddb9ee into master Jul 13, 2020
@mmarkelov mmarkelov deleted the Add-ability-to-check-cjs-config branch July 13, 2020 11:02
@fschoenfeldt
Copy link
Contributor

So nice, thank you guys for replying so quick and implementing it! @mmarkelov @mxschmitt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add jest-playwright.config.cjs to utils.ts

3 participants