Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Allow configure launch browser type #193

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Allow configure launch browser type #193

merged 1 commit into from
Jul 4, 2020

Conversation

mmarkelov
Copy link
Member

@mmarkelov mmarkelov commented Jul 3, 2020 •
edited by mxschmitt
Loading

closes #188
closes #192

@mmarkelov mmarkelov requested a review from mxschmitt as a code owner July 3, 2020 18:38
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

Pull Request Test Coverage Report for Build 156881081

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.791%
Totals Coverage Status
Change from base Build 155480860: 0.2%
Covered Lines: 82
Relevant Lines: 86
💛 - Coveralls

@mmarkelov mmarkelov mentioned this pull request Jul 3, 2020
Closed
mxschmitt
mxschmitt approved these changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if we can create a beta release out of it, so we can test it on our examples repository.

@mmarkelov mmarkelov merged commit 55570a2 into master Jul 4, 2020
@mmarkelov mmarkelov deleted the Allow-configure-launch-browser-type branch July 4, 2020 08:44
@mmarkelov mmarkelov mentioned this pull request Jul 4, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mxschmitt mxschmitt mxschmitt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting up an environment with persistentContext
2 participants
@mmarkelov @mxschmitt