Skip to content

Integrate error handling #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 21, 2019
Merged

Integrate error handling #53

merged 9 commits into from
Aug 21, 2019

Conversation

@harukasan
Copy link
Member

This PR introduces better error handling and removes panics.
Also fixes #51 .

@harukasan harukasan requested a review from unak August 21, 2019 07:04
@harukasan harukasan self-assigned this Aug 21, 2019
@harukasan harukasan mentioned this pull request Aug 21, 2019
Closed
unak
unak approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@unak unak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'v committed the fix of a test, then, it seems OK for me!

@harukasan harukasan changed the title Integration error handling Integrate error handling Aug 21, 2019
@harukasan harukasan merged commit 83566ac into master Aug 21, 2019
@harukasan harukasan deleted the feature/integration_errors branch August 21, 2019 08:07
@harukasan harukasan mentioned this pull request Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unak unak unak approved these changes

Assignees

@harukasan harukasan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

signal SIGSEGV: segmentation violation

3 participants

@harukasan @unak