Skip to content

Conversation

@sam-pitch
Copy link

currently pptxgenjs swallows the exception when an image experiences an error during fetch. We should forward this so we can get some more helpful info in bugsnag.

@sam-pitch sam-pitch requested a review from zarkone December 8, 2022 14:34
@sam-pitch sam-pitch self-assigned this Dec 8, 2022
@linear
Copy link

linear bot commented Dec 8, 2022

SWI-405 Bugsnag: Critical about images which couldn't be loaded during file write.

| ERROR! Unable to load image (image.onerror) |

https://app.bugsnag.com/pitch-software-gmbh/app/errors/63888025190c81000a061681?filters[event.since]=7d&filters[app.release_stage]=stable&filters[event.message]=[pptx-exporter]

| ERROR! Unable to load image (xhr.onerror) |

https://app.bugsnag.com/pitch-software-gmbh/app/errors/6388923d437daa0009ed801d?filters[event.since]=7d&filters[app.release_stage]=stable&filters[event.message]=[pptx-exporter]

We've seen this errors a few time. Our speculation is that the user is attempting export with a shaky internet connection which fails to fetch the image from network.

We could try to put some retries in PptxGenJS so that it attempts the write more persistently. If the user's connection is mostly fine though, and they try again. Hopefully they eventually experience a successful export.

@sam-pitch sam-pitch merged commit 0f13282 into pitch-main Dec 9, 2022
@sam-pitch sam-pitch deleted the samuel/swi-405-bugsnag-critical-about-images-which-2 branch December 9, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants