add pie chart explosion opt to charts #17
Conversation
SWI-221 Chart: Pie options
Unsupported options
Other problems
|
src/gen-charts.ts
Outdated
| strXml += '<c:' + chartType + 'Chart>' | ||
| strXml += ' <c:varyColors val="1"/>' | ||
| strXml += '<c:ser>' | ||
| if (opts.chartPieExplosion) { |
There was a problem hiding this comment.
we'll need to do a couple of safety checks before passing it to the xml i.e. is it a valid number?
There was a problem hiding this comment.
is the following fine?
if (opts.chartPieExplosion && Number.isInteger(opts.chartPieExplosion)) {There was a problem hiding this comment.
Do we support floats? And is there a min or max limit? I've seen some PPTX errors before because the number were out of range.
There was a problem hiding this comment.
and Explosion needs to be an integer value according to c-rex
I don't think we should be overly defensive here. The values which Pitch can produce are quite narrow (0 - 10).
| * @default 0 | ||
| */ | ||
| firstSliceAng?: number | ||
| chartPieExplosion?: number |
There was a problem hiding this comment.
Does this protect us from bad inputs without having to add manual inline checks? @tjinauyeung
There was a problem hiding this comment.
No, these definitions are not checked unfortunately. We're not using any of the TS definitions when using the library.
3 participants
Adds the "explosion" prop to PptxGenJS. This will allow us to get something approximating our pie chart padding