Skip to content

only override missing props on the text run, not just falsey ones #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

only override missing props on the text run, not just falsey ones #16

merged 1 commit into from
Sep 13, 2022
+19 −17

Conversation

@sam-pitch
Copy link

@sam-pitch sam-pitch commented Sep 12, 2022 •
edited
Loading

Relates to pitch-app #46861

@sam-pitch sam-pitch self-assigned this Sep 12, 2022
@sam-pitch sam-pitch requested a review from seekuehe September 12, 2022 16:15
tjinauyeung
tjinauyeung reviewed Sep 13, 2022
View reviewed changes
@sam-pitch sam-pitch merged commit 5898919 into pitch-main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@seekuehe seekuehe seekuehe approved these changes

@tjinauyeung tjinauyeung tjinauyeung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sam-pitch sam-pitch

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sam-pitch @seekuehe @tjinauyeung