Add Example for useReducer with types. #118
Conversation
|
Hey, sorry for delay got a really tough week, I'll get to it tomorrow. Cheers! |
piotrwitek
left a comment
piotrwitek
left a comment
There was a problem hiding this comment.
It looks quite good! Just need to make a couple of fixes following the comments and we are good to go. Thanks!
playground/package.json
Outdated
| "axios": "0.18.0", | ||
| "cuid": "2.1.1", | ||
| "react": "16.4.0", | ||
| "react": "^16.8.0-alpha.0", |
There was a problem hiding this comment.
Please correct all the added packages to use locked version
There was a problem hiding this comment.
@piotrwitek Sorry, I can't understand that what I should. How do I correct it to use the locked version?
There was a problem hiding this comment.
remove ^ prefix, everywhere you added them
playground/src/hooks/use-reducer.tsx
Outdated
| } | ||
|
|
||
| interface Action { | ||
| type: string; |
There was a problem hiding this comment.
should be an union, right now it's not type-safe
please declare:
type Action =
| { type: 'reset' }
| { type: 'increment' }
...
|
@piotrwitek I fixed the PR according to your review! please confirm:pray: |
|
Yeah, that looks great! Thanks for contribution. |
2 participants
resolve #102
Caution
I installed
[email protected]and@types/[email protected]( and dependencies ) to use React Hooks.