-
Notifications
You must be signed in to change notification settings - Fork 704
br: correct the store speed #20973 #21859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains a mix of unrelated changes. The title suggests a correction to the BR store speed, which is reflected in br/br-snapshot-guide.md
. However, the PR also introduces a very large set of new Python scripts for a documentation translation workflow, changes a repository owner in a script to a personal username, and removes some feature documentation from system-variables.md
. It's highly recommended to split these unrelated changes into separate pull requests for clarity and easier review. My feedback focuses on the specific changes in the diff.
62df7e9
to
78c4089
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?