cloud: add the DB Audit Logging feature in console #21788
+452
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
ti-chi-bot
bot
added
the
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @shiyuhang0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly updates the documentation for database audit logging within TiDB Cloud Essential clusters. It introduces comprehensive guides for managing audit logging directly through the console, complementing existing CLI instructions. Furthermore, the documentation now details how to configure audit logs to be stored in a wider array of external cloud storage solutions, enhancing flexibility and compliance options for users.
Highlights
- New Database Audit Logging Documentation: Introduced comprehensive documentation for Database Audit Logging specifically for TiDB Cloud Essential clusters, replacing previous serverless audit logging content.
- Console-Based Audit Log Management: Added detailed instructions for managing database audit logging directly through the TiDB Cloud console, including enabling/disabling, editing configurations, and managing filter rules, alongside existing CLI methods.
- Expanded External Storage Options: Provided extensive guidance on configuring audit logs to be stored in various external cloud storage services, such as Amazon S3, Google Cloud Storage, Azure Blob Storage, and Alibaba Cloud OSS.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
the
size/XXL
Closed
hfxsd
added
translation/no-need
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
hfxsd
changed the title
Oreoxmt
reviewed
Sep 19, 2025
Oreoxmt
reviewed
Sep 23, 2025
Oreoxmt
added
the
do-not-merge/hold
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+69
to
+72
| To store audit logs to Google Cloud Storage, you need to provide the following information: | ||
|
|
||
| - URI: `gs://<bucket-name>/<folder-path>/` | ||
| - Access credential: a [service account key](https://cloud.google.com/iam/docs/creating-managing-service-account-keys) for your bucket. Make sure the service account key has the `storage.objects.create` and `storage.objects.delete` permissions. |
There was a problem hiding this comment.
Suggested change
| To store audit logs to Google Cloud Storage, you need to provide the following information: | |
| - URI: `gs://<bucket-name>/<folder-path>/` | |
| - Access credential: a [service account key](https://cloud.google.com/iam/docs/creating-managing-service-account-keys) for your bucket. Make sure the service account key has the `storage.objects.create` and `storage.objects.delete` permissions. | |
| To store audit logs in Google Cloud Storage, you need to provide the following information: | |
| - URI: `gs://<bucket-name>/<folder-path>/` | |
| - Access credential: a [service account key](https://cloud.google.com/iam/docs/creating-managing-service-account-keys) with the `storage.objects.create` and `storage.objects.delete` permissions. |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+78
to
+81
| To store audit logs to Azure Blob Storage, you need to provide the following information: | ||
|
|
||
| - URI: `azure://<account-name>.blob.core.windows.net/<container-name>/<folder-path>/` or `https://<account-name>.blob.core.windows.net/<container-name>/<folder-path>/` | ||
| - Access credential: a [shared access signature (SAS) token](https://docs.microsoft.com/en-us/azure/storage/common/storage-sas-overview) for your Azure Blob Storage container. Make sure the SAS token has the `Read` and `Write` permissions on the `Container` and `Object` resources. |
There was a problem hiding this comment.
Suggested change
| To store audit logs to Azure Blob Storage, you need to provide the following information: | |
| - URI: `azure://<account-name>.blob.core.windows.net/<container-name>/<folder-path>/` or `https://<account-name>.blob.core.windows.net/<container-name>/<folder-path>/` | |
| - Access credential: a [shared access signature (SAS) token](https://docs.microsoft.com/en-us/azure/storage/common/storage-sas-overview) for your Azure Blob Storage container. Make sure the SAS token has the `Read` and `Write` permissions on the `Container` and `Object` resources. | |
| To store audit logs in Azure Blob Storage, you need to provide the following information: | |
| - URI: `azure://<account-name>.blob.core.windows.net/<container-name>/<folder-path>/` or `https://<account-name>.blob.core.windows.net/<container-name>/<folder-path>/` | |
| - Access credential: a [shared access signature (SAS) token](https://docs.microsoft.com/en-us/azure/storage/common/storage-sas-overview) with `Read` and `Write` permissions on the `Container` and `Object` resources. |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+87
to
+90
| To store audit logs to Alibaba Cloud OSS, you need to provide the following information: | ||
|
|
||
| - URI: `oss://<bucket-name>/<folder-path>/` | ||
| - Access credential: An [AccessKey pair](https://www.alibabacloud.com/help/en/ram/user-guide/create-an-accesskey-pair) for your Alibaba Cloud account. Make sure the AccessKey pair has the `oss:PutObject` and `oss:GetBucketInfo` permissions to allow data export to the OSS bucket. |
There was a problem hiding this comment.
Suggested change
| To store audit logs to Alibaba Cloud OSS, you need to provide the following information: | |
| - URI: `oss://<bucket-name>/<folder-path>/` | |
| - Access credential: An [AccessKey pair](https://www.alibabacloud.com/help/en/ram/user-guide/create-an-accesskey-pair) for your Alibaba Cloud account. Make sure the AccessKey pair has the `oss:PutObject` and `oss:GetBucketInfo` permissions to allow data export to the OSS bucket. | |
| To store audit logs in Alibaba Cloud OSS, you need to provide the following information: | |
| - URI: `oss://<bucket-name>/<folder-path>/` | |
| - Access credential: an [AccessKey pair](https://www.alibabacloud.com/help/en/ram/user-guide/create-an-accesskey-pair) with the `oss:PutObject` and `oss:GetBucketInfo` permissions to allow data export to the OSS bucket. |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| The following table shows all event classes in database audit logging: | ||
|
|
||
| | Event Class | Description | Parent-class | |
There was a problem hiding this comment.
Suggested change
| | Event Class | Description | Parent-class | | |
| | Event class | Description | Parent-class | |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| ### Enable audit logging | ||
|
|
||
| You can enable audit logging for a {{{ .essential }}} cluster. |
There was a problem hiding this comment.
Suggested change
| You can enable audit logging for a {{{ .essential }}} cluster. | |
| You can enable audit logging for a {{{ .essential }}} cluster using the TiDB Cloud console or the TiDB Cloud CLI. |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| > **Note:** | ||
| > | ||
| > Only enabling audit logging will not generate audit logs. You need to configure filters to specify what events to log. For more information, see [Manage audit logging filter rules](#manage-audit-logging-filter-rules). |
There was a problem hiding this comment.
Suggested change
| > Only enabling audit logging will not generate audit logs. You need to configure filters to specify what events to log. For more information, see [Manage audit logging filter rules](#manage-audit-logging-filter-rules). | |
| > Enabling audit logging alone does not generate audit logs. You must also configure filters to specify which events to log. For more information, see [Manage audit logging filter rules](#manage-audit-logging-filter-rules). |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+146
to
+148
| > **Tip:** | ||
| > | ||
| > You can use the combo box in the upper-left corner to switch between organizations, projects, and clusters. |
There was a problem hiding this comment.
Suggested change
| > **Tip:** | |
| > | |
| > You can use the combo box in the upper-left corner to switch between organizations, projects, and clusters. | |
| > **Tip:** | |
| > | |
| > You can use the combo box in the upper-left corner to switch between organizations, projects, and clusters. |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+154
to
+156
| 4. Select the storage location of the audit logs and fill in the necessary information, then click **Test Connection and Next** or **Next**. For more information about the available storage locations, see [Audit logging locations](#audit-logging-locations). | ||
|
|
||
| 5. In the **Database Audit Logging Settings** dialog box, fill in the log file rotation and log redaction settings, and then click **Save**. |
There was a problem hiding this comment.
Suggested change
| 4. Select the storage location of the audit logs and fill in the necessary information, then click **Test Connection and Next** or **Next**. For more information about the available storage locations, see [Audit logging locations](#audit-logging-locations). | |
| 5. In the **Database Audit Logging Settings** dialog box, fill in the log file rotation and log redaction settings, and then click **Save**. | |
| 4. Select a storage location for the audit logs and fill in the required information. Then click **Test Connection and Next** or **Next**. For more information about available storage locations, see [Audit logging locations](#audit-logging-locations). | |
| 5. In the **Database Audit Logging Settings** dialog, fill in the log file rotation and log redaction settings, and then click **Save**. |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| <div label="CLI"> | ||
|
|
||
| Take Amazon S3 storage as an example. Run the following command to enable audit logging and store the audit logs to Amazon S3: |
There was a problem hiding this comment.
Suggested change
| Take Amazon S3 storage as an example. Run the following command to enable audit logging and store the audit logs to Amazon S3: | |
| Take Amazon S3 storage as an example. To enable audit logging and store audit logs in Amazon S3, run the following command: |
Oreoxmt
reviewed
Oct 10, 2025
| Take Amazon S3 storage as an example. Run the following command to enable audit logging and store the audit logs to Amazon S3: | ||
|
|
||
| ```shell | ||
| ticloud serverless audit-log config update -c <cluster-id> --enabled --cloud-storage S3 --s3.uri <s3-url> --s3.access-key-id <s3-access-key-id> --s3.secret-access-key <s3-secret-access-key> --rotation-size-mib <size-in-mb> --rotation-interval-minutes <interval-in-minutes> --unredacted=<true|false> |
There was a problem hiding this comment.
Suggested change
| ticloud serverless audit-log config update -c <cluster-id> --enabled --cloud-storage S3 --s3.uri <s3-url> --s3.access-key-id <s3-access-key-id> --s3.secret-access-key <s3-secret-access-key> --rotation-size-mib <size-in-mb> --rotation-interval-minutes <interval-in-minutes> --unredacted=<true|false> | |
| ticloud serverless audit-log config update -c <cluster-id> --enabled --cloud-storage S3 --s3.uri <s3-url> --s3.access-key-id <s3-access-key-id> --s3.secret-access-key <s3-secret-access-key> --rotation-size-mib <size-in-mb> --rotation-interval-minutes <interval-in-minutes> --unredacted=<true|false> |
Oreoxmt
reviewed
Oct 10, 2025
| ticloud serverless audit-log config update -c <cluster-id> --enabled --cloud-storage S3 --s3.uri <s3-url> --s3.access-key-id <s3-access-key-id> --s3.secret-access-key <s3-secret-access-key> --rotation-size-mib <size-in-mb> --rotation-interval-minutes <interval-in-minutes> --unredacted=<true|false> | ||
| ``` | ||
|
|
||
| `--rotation-size-mib`, `--rotation-interval-minutes`, and `--unredacted` are optional parameters. If you do not specify them, the default values are used. |
There was a problem hiding this comment.
Suggested change
| `--rotation-size-mib`, `--rotation-interval-minutes`, and `--unredacted` are optional parameters. If you do not specify them, the default values are used. | |
| The `--rotation-size-mib`, `--rotation-interval-minutes`, and `--unredacted` parameters are optional. If you do not specify them, the default values are used. |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| 3. On the **DB Audit Logging** page, click **Settings**. | ||
|
|
||
| 4. In the **Database Audit Logging Settings** dialog box, fill the log file rotation and log redaction settings, and then click **Save**. |
There was a problem hiding this comment.
Suggested change
| 4. In the **Database Audit Logging Settings** dialog box, fill the log file rotation and log redaction settings, and then click **Save**. | |
| 4. In the **Database Audit Logging Settings** dialog, update the log file rotation or log redaction settings, and then click **Save**. |
Oreoxmt
reviewed
Oct 10, 2025
| </div> | ||
|
|
||
| <div label="CLI"> | ||
|
|
There was a problem hiding this comment.
Suggested change
| To update the audit logging settings using the TiDB Cloud CLI, run the following command: | |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| 3. On the **DB Audit Logging** page, click **...** in the upper-right corner, and then click **Disable**. | ||
|
|
||
| 4. In the **Disable DB Audit Logging** dialog box, click **Disable**. |
There was a problem hiding this comment.
Suggested change
| 4. In the **Disable DB Audit Logging** dialog box, click **Disable**. | |
| 4. In the **Disable DB Audit Logging** dialog, click **Disable**. |
Oreoxmt
reviewed
Oct 10, 2025
| </div> | ||
|
|
||
| <div label="CLI"> | ||
|
|
There was a problem hiding this comment.
Suggested change
| To disable audit logging using the TiDB Cloud CLI, run the following command: | |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| ## Manage audit logging filter rules | ||
|
|
||
| You can create, edit, disable, and delete a audit logging filter rule. |
There was a problem hiding this comment.
Suggested change
| You can create, edit, disable, and delete a audit logging filter rule. | |
| You can create, edit, disable, and delete an audit logging filter rule. |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+246
to
+248
| > **Tip:** | ||
| > | ||
| > You can use the combo box in the upper-left corner to switch between organizations, projects, and clusters. |
There was a problem hiding this comment.
Suggested change
| > **Tip:** | |
| > | |
| > You can use the combo box in the upper-left corner to switch between organizations, projects, and clusters. | |
| > **Tip:** | |
| > | |
| > You can use the combo box in the upper-left corner to switch between organizations, projects, and clusters. |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| 3. On the **DB Audit Logging** page, click **Add Filter Rule**. | ||
|
|
||
| 4. Fill in the **Filter Name**, **SQL Users**, and **Filter Rule** fields in the **Add Filter Rule** dialog box, and then click **Confirm**. For more information about the fields, see [Audit logging filter rules](#audit-logging-filter-rules). |
There was a problem hiding this comment.
Suggested change
| 4. Fill in the **Filter Name**, **SQL Users**, and **Filter Rule** fields in the **Add Filter Rule** dialog box, and then click **Confirm**. For more information about the fields, see [Audit logging filter rules](#audit-logging-filter-rules). | |
| 4. In the **Add Filter Rule** dialog, fill in the **Filter Name**, **SQL Users**, and **Filter Rule** fields, and then click **Confirm**. For more information about these fields, see [Audit logging filter rules](#audit-logging-filter-rules). |
Oreoxmt
reviewed
Oct 10, 2025
| </div> | ||
|
|
||
| <div label="CLI"> | ||
|
|
There was a problem hiding this comment.
Suggested change
| To create a filter rule using the TiDB Cloud CLI, run the following command: | |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+280
to
+282
| 3. On the **DB Audit Logging** page, find the filter rule you want to edit, click **...** in its row, and then click **Edit**. | ||
|
|
||
| 4. Fill in the **Filter Name** and **Filter Rule** fields in the **Edit Filter Rule** dialog box, and then click **Confirm**. |
There was a problem hiding this comment.
Suggested change
| 3. On the **DB Audit Logging** page, find the filter rule you want to edit, click **...** in its row, and then click **Edit**. | |
| 4. Fill in the **Filter Name** and **Filter Rule** fields in the **Edit Filter Rule** dialog box, and then click **Confirm**. | |
| 3. On the **DB Audit Logging** page, locate the filter rule you want to edit, click **...** in its row, and then click **Edit**. | |
| 4. In the **Edit Filter Rule** dialog, update the **Filter Name** or **Filter Rule** field, and then click **Confirm**. |
Oreoxmt
reviewed
Oct 10, 2025
| </div> | ||
|
|
||
| <div label="CLI"> | ||
|
|
There was a problem hiding this comment.
Suggested change
| To edit a filter rule using the TiDB Cloud CLI, run the following command: | |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+308
to
+310
| 3. On the **DB Audit Logging** page, choose the filter rule that you want to disable. | ||
|
|
||
| 4. Turn off the slider to disable the filter rule. |
There was a problem hiding this comment.
Suggested change
| 3. On the **DB Audit Logging** page, choose the filter rule that you want to disable. | |
| 4. Turn off the slider to disable the filter rule. | |
| 3. On the **DB Audit Logging** page, locate the filter rule you want to disable, and turn off the toggle to disable the filter rule. |
Oreoxmt
reviewed
Oct 10, 2025
| </div> | ||
|
|
||
| <div label="CLI"> | ||
|
|
There was a problem hiding this comment.
Suggested change
| To disable a filter rule using the TiDB Cloud CLI, run the following command: | |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+336
to
+338
| 3. On the **DB Audit Logging** page, choose the filter rule you want to delete and click **...**. | ||
|
|
||
| 4. Click **Delete** and then click **I understand. Delete it** to delete the filter rule. |
There was a problem hiding this comment.
Suggested change
| 3. On the **DB Audit Logging** page, choose the filter rule you want to delete and click **...**. | |
| 4. Click **Delete** and then click **I understand. Delete it** to delete the filter rule. | |
| 3. On the **DB Audit Logging** page, locate the filter rule you want to delete and click **...**. | |
| 4. Click **Delete**, and then click **I understand. Delete it** to confirm. |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| ## Access audit logging with TiDB Cloud Storage | ||
|
|
||
| When you store audit logs in TiDB Cloud, {{{ .essential }}} stores them as readable text files named `YYYY-MM-DD-<index>.log`, which you can access and download. |
There was a problem hiding this comment.
Suggested change
| When you store audit logs in TiDB Cloud, {{{ .essential }}} stores them as readable text files named `YYYY-MM-DD-<index>.log`, which you can access and download. | |
| When you store audit logs in TiDB Cloud, {{{ .essential }}} saves them as readable text files named `YYYY-MM-DD-<index>.log`. You can view and download these files from the TiDB Cloud console or using the TiDB Cloud CLI. |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+357
to
+358
| > {{{ .essential }}} does not guarantee sequential ordering of audit logs. The log file named `YYYY-MM-DD-<index>.log` might contain the audit logs in previous days. | ||
| > If you want to retrieve all logs from a specific date (for example, January 1, 2025), specifying `--start-date 2025-01-01` and `--end-date 2025-01-02` usually works. But under extreme conditions, you might need to download all log files and order them by the `TIME` field. |
There was a problem hiding this comment.
Suggested change
| > {{{ .essential }}} does not guarantee sequential ordering of audit logs. The log file named `YYYY-MM-DD-<index>.log` might contain the audit logs in previous days. | |
| > If you want to retrieve all logs from a specific date (for example, January 1, 2025), specifying `--start-date 2025-01-01` and `--end-date 2025-01-02` usually works. But under extreme conditions, you might need to download all log files and order them by the `TIME` field. | |
| > - {{{ .essential }}} does not guarantee that audit logs are stored in sequential order. A log file named `YYYY-MM-DD-<index>.log` might contain entries from earlier dates. | |
| > - To retrieve all logs for a specific date (for example, January 1, 2025), set `--start-date 2025-01-01` and `--end-date 2025-01-02`. In some cases, you might need to download all log files and sort them by the `TIME` field. |
Oreoxmt
reviewed
Oct 10, 2025
| 2. Click the name of your target cluster to go to its overview page, and then click **Settings** > **DB Audit Logging** in the left navigation pane. | ||
|
|
||
| 3. On the **DB Audit Logging** page, you can view the list of audit logs under `TiDB Cloud Storage`. |
There was a problem hiding this comment.
Suggested change
| 3. On the **DB Audit Logging** page, you can view the list of audit logs under `TiDB Cloud Storage`. | |
| 3. On the **DB Audit Logging** page, you can view the list of audit logs under **TiDB Cloud Storage**. |
Oreoxmt
reviewed
Oct 10, 2025
| </div> | ||
|
|
||
| <div label="CLI"> | ||
|
|
There was a problem hiding this comment.
Suggested change
| To download audit logs using the TiDB Cloud CLI, run the following command: | |
Oreoxmt
reviewed
Oct 10, 2025
Comment on lines
+383
to
+384
| - `start-date`: The start date of the audit log that you want to download in the format of `YYYY-MM-DD`, for example `2025-01-01`. | ||
| - `end-date`: The end date of the audit log that you want to download in the format of `YYYY-MM-DD`, for example `2025-01-01`. |
There was a problem hiding this comment.
Suggested change
| - `start-date`: The start date of the audit log that you want to download in the format of `YYYY-MM-DD`, for example `2025-01-01`. | |
| - `end-date`: The end date of the audit log that you want to download in the format of `YYYY-MM-DD`, for example `2025-01-01`. | |
| - `start-date`: the start date of the audit logs to download, in the format of `YYYY-MM-DD`, for example, `2025-01-01`. | |
| - `end-date`: the end date of the audit logs to download, in the format of `YYYY-MM-DD`, for example, `2025-01-01`. |
Oreoxmt
reviewed
Oct 10, 2025
|
|
||
| ## Audit logging limitations | ||
|
|
||
| {{{ .essential }}} does not guarantee the sequential order of audit logs, which means that you might have to review all log files to view the latest events. To sort the logs chronologically, you can use the `TIME` field in the audit logs. |
There was a problem hiding this comment.
Suggested change
| {{{ .essential }}} does not guarantee the sequential order of audit logs, which means that you might have to review all log files to view the latest events. To sort the logs chronologically, you can use the `TIME` field in the audit logs. | |
| {{{ .essential }}} does not guarantee the sequential order of audit logs, which means that you might have to review all log files find the most recent events. To sort the logs chronologically, you can use the `TIME` field in the audit logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?