Skip to content

security: add docs for reloading certs in TLS between TiDB components doc #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2025
Merged

security: add docs for reloading certs in TLS between TiDB components doc #2930

merged 4 commits into from
Oct 11, 2025

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 19, 2025 •
edited by hfxsd
Loading

What is changed, added, or deleted? (Required)

Add a description that TiDB components can automatically reload the certificates / keys. The users don't need to restart the whole cluster to reload certs/keys.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version for v1.x)
  • feature/v2 (the latest development version for v2.x)
  • v2.0 (TiDB Operator 2.0 versions)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Sep 19, 2025
@pingcap-cla-assistant pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Sep 19, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2025
@hfxsd hfxsd self-assigned this Sep 19, 2025
@hfxsd hfxsd requested a review from dveeden September 19, 2025 09:46
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 19, 2025
hfxsd
hfxsd reviewed Sep 22, 2025
View reviewed changes
hfxsd
hfxsd reviewed Sep 22, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 22, 2025
@dveeden
Copy link
Contributor

dveeden commented Sep 26, 2025

Should we link to https://docs.pingcap.com/tidb-in-kubernetes/stable/renew-tls-certificate/ ?

@dveeden dveeden mentioned this pull request Oct 6, 2025
Open
8 tasks
hfxsd
hfxsd reviewed Oct 11, 2025
View reviewed changes
hfxsd
hfxsd reviewed Oct 11, 2025
View reviewed changes
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 11, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-22 07:22:25.646345197 +0000 UTC m=+254955.716838880: ☑️ agreed by dveeden.
  • 2025-10-11 07:12:48.901249722 +0000 UTC m=+510757.932349040: ☑️ agreed by hfxsd.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 11, 2025

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt October 11, 2025 07:16
Oreoxmt
Oreoxmt reviewed Oct 11, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Oct 11, 2025
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Oct 11, 2025
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 11, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 11, 2025
@ti-chi-bot ti-chi-bot bot merged commit 7cafa88 into pingcap:master Oct 11, 2025
14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2949.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2025
Merged
7 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 11, 2025
@ti-chi-bot
security: add docs for reloading certs in `TLS between TiDB component…
8d244fc 
…s` doc (#2930) (#2949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dveeden dveeden dveeden approved these changes

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@hfxsd hfxsd

Labels

approved lgtm needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YangKeao @dveeden @Oreoxmt @hfxsd @ti-chi-bot