Skip to content

enable-tls-between-components: add TiProxy for cert-manager #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2025
Merged

enable-tls-between-components: add TiProxy for cert-manager #2929

merged 6 commits into from
Oct 21, 2025

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Sep 16, 2025

First-time contributors' checklist

What is changed, added, or deleted? (Required)

For cert-manager the description for the TiProxy certificate/secret was missing.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version for v1.x)
  • feature/v2 (the latest development version for v2.x)
  • v2.0 (TiDB Operator 2.0 versions)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@dveeden dveeden requested review from djshow832 and hfxsd September 16, 2025 15:52
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2025
@dveeden dveeden requested a review from YangKeao September 23, 2025 07:22
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2025

@djshow832: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

YangKeao
YangKeao approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2025

@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd self-assigned this Oct 20, 2025
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. and removed missing-translation-status This PR does not have translation status info. labels Oct 20, 2025
@hfxsd
Add TiProxy server certificate instructions
63c9cb6 
Added detailed steps and example configuration for issuing TiProxy server certificates using cert-manager in both English and Chinese documentation. This helps users enable TLS between TiProxy and other components in TiDB clusters.
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2025
@hfxsd
Remove trailing whitespace in TLS docs
46309e9 
Cleaned up unnecessary trailing spaces in both English and Chinese versions of the TLS enablement documentation for improved formatting.
@hfxsd hfxsd requested a review from Oreoxmt October 20, 2025 08:42
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 20, 2025
Oreoxmt
Oreoxmt reviewed Oct 21, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Oct 21, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Oct 21, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Oct 21, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Oct 21, 2025
View reviewed changes
Oreoxmt
Oreoxmt reviewed Oct 21, 2025
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Oct 21, 2025
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 21, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2025

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-21 02:49:01.117318514 +0000 UTC m=+753647.194571064: ☑️ agreed by Oreoxmt.
  • 2025-10-21 09:36:46.603776487 +0000 UTC m=+778112.681029047: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 21, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 21, 2025
@ti-chi-bot ti-chi-bot bot merged commit 2578d40 into pingcap:master Oct 21, 2025
14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2959.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2025
Merged
8 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 21, 2025
@ti-chi-bot
enable-tls-between-components: add TiProxy for cert-manager (#2929) (#…
deb857f 
…2959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YangKeao YangKeao YangKeao approved these changes

@djshow832 djshow832 djshow832 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@hfxsd hfxsd

Labels

approved lgtm needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dveeden @hfxsd @ti-chi-bot @YangKeao @djshow832 @Oreoxmt