Skip to content

Conversation

@wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Nov 24, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 24, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2025

@wjhuang2016: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 3d748fc link true /test pull-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- `DECIMAL` 精度修改
-`VARCHAR(10)``VARCHAR(5)` 的长度压缩

从 v8.5.4 版本起,TiDB 优化了部分 Reorg-Data 类型变更的执行效率。在 [SQL 模式](/sql-mode.md)非严格模式(即 `sql_mode` 值包含 `STRICT_TRANS_TABLES``STRICT_ALL_TABLES`),以下类型变更将不再进行数据重建(Meta-Only 变更):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
从 v8.5.4 版本起,TiDB 优化了部分 Reorg-Data 类型变更的执行效率。在 [SQL 模式](/sql-mode.md)非严格模式(即 `sql_mode` 值包含 `STRICT_TRANS_TABLES``STRICT_ALL_TABLES`),以下类型变更将不再进行数据重建(Meta-Only 变更)
从 v8.5.4 版本起,TiDB 优化了部分 Reorg-Data 类型变更的执行效率。在 [SQL 模式](/sql-mode.md)严格模式(即 `sql_mode` 值包含 `STRICT_TRANS_TABLES``STRICT_ALL_TABLES`),以下类型变更将不再进行表数据重建,只进行部分索引的重建

Copy link
Collaborator

@qiancai qiancai Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update v8.5.4 to v8.5.5 if it is planned in v8.5.5

@qiancai qiancai self-assigned this Nov 25, 2025
@qiancai qiancai added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@qiancai
Copy link
Collaborator

qiancai commented Nov 26, 2025

add the do-not-merge/hold label as the change in this PR won't be included in v8.5.4

- 整数类型之间的变更(例如 `BIGINT``INT`
- 字符串类型之间的变更(例如 `VARCHAR(200)``VARCHAR(100)`

注意:VARCHAR 类型往 CHAR 类型变更时,要求所有的旧数据的尾部均不包含空格,否则需要进行 Reorg-Data。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
注意:VARCHAR 类型往 CHAR 类型变更时,要求所有的旧数据的尾部均不包含空格,否则需要进行 Reorg-Data。
> **注意:**
>
> `VARCHAR` 转换为 `CHAR` 时,要求所有原数据的末尾均不包含空格;若不满足该条件,TiDB 仍会执行 Reorg-Data。

- `DECIMAL` 精度修改
-`VARCHAR(10)``VARCHAR(5)` 的长度压缩

从 v8.5.4 版本起,TiDB 优化了部分 Reorg-Data 类型变更的执行效率。在 [SQL 模式](/sql-mode.md)非严格模式(即 `sql_mode` 值包含 `STRICT_TRANS_TABLES``STRICT_ALL_TABLES`),以下类型变更将不再进行数据重建(Meta-Only 变更):
Copy link
Collaborator

@qiancai qiancai Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update v8.5.4 to v8.5.5 if it is planned in v8.5.5

@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants