update urllib3_response.headers.get as getheader is deprecated #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up to #195, which updated to use
urllib.headers
-- there's also a deprecation forgetheader
coming: urllib3/urllib3#2814Solution
Updated the call in
rest.py
to use.get
instead of.getheader
; based on the code this should be compatible with 1.2.1, our current min versionType of Change
Test Plan
REST requests should work without a notice in URLLib3 2.0.4+