-
Notifications
You must be signed in to change notification settings - Fork 12
[Document Editor][Context Menu Options][Detail view][Translations] New document #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Document Editor][Context Menu Options][Detail view][Translations] New document #2169
Conversation
… new document for a translation #1678
…-optionsdetail-viewtranslations-new-document' into 1678-document-editorcontext-menu-optionsdetail-viewtranslations-new-document
What's still missing here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already pretty good, but please check my comments :)
assets/js/src/core/modules/document/actions/translations/components/new-translation-modal.tsx
Outdated
Show resolved
Hide resolved
assets/js/src/core/modules/document/actions/translations/components/new-translation-modal.tsx
Show resolved
Hide resolved
assets/js/src/core/modules/document/actions/translations/components/new-translation-modal.tsx
Outdated
Show resolved
Hide resolved
assets/js/src/core/modules/document/actions/translations/components/new-translation-modal.tsx
Outdated
Show resolved
Hide resolved
assets/js/src/core/modules/document/actions/translations/components/new-translation-modal.tsx
Show resolved
Hide resolved
assets/js/src/core/modules/document/actions/translations/components/new-translation-modal.tsx
Outdated
Show resolved
Hide resolved
assets/js/src/core/modules/document/actions/translations/use-translations.tsx
Show resolved
Hide resolved
… and react to error responses of parent data request #1678
|
Changes in this pull request
Resolves #1678
Additional info