Be explicit with create_admin function and tables= that we're not creating them, but registering them
#460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more exact overview of what adding tables to the `create_admin` function does for beginners. Current `agsi new` cli example (in my opinion) isn't quite clear enough right now. 1. Add named argument to example 2. Add endpoint docs for `tables=`
|
This PR has been marked as stale because it has been open for 30 days with no activity. Are there any blockers, or should this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more exact overview of what adding tables to the
create_adminfunction does for beginners. The particular wording can be different if you prefer, but "add" in my experience (as you're using migrations inagsi newfor Piccolo ORM) can be confused with "create" (as increate_db_tables). Will also eventually slightly rewrite the "Getting started guide" foragsi new(will explain later).tables=Fixes piccolo-orm/piccolo#1276