Use an non-interned zend_string for registerExtension on ZTS #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valgrind checks for invalid memory accesses and memory leaks. "-m" makes php unit tests use valgrind (and malloc instead of emalloc, etc.)
TysonAndre
changed the title
v8js_class.cc
Outdated
| } | ||
| delete jsext->extension; | ||
| // jsext->name and jsext->source are interned, this would do nothing. | ||
| // Interned strings will be freed after module shutdown (On ZTS - But on NTS, they're actually interned) |
Member
There was a problem hiding this comment.
I think this comment is (now) misleading/wrong, since the strings are guaranteed not to be interned
(There are no interned strings in ZTS, see the definition of zend_new_interned_string_int) On NTS, strings must be non-interned in order to last until module shutdown. interned strings are cleaned up before module shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(There are no interned strings in ZTS, see the definition of
zend_new_interned_string_int)
Fixes #247
See discussion in #254
On NTS, strings must be non-interned in order to last until module shutdown. If registerExtension is passed a literal string constant, it is probably(?) interned.
ZTS doesn't have any interned strings.
Only one test has been run with valgrind(tests/extensions_basic.phpt)