This repository was archived by the owner on Mar 29, 2024. It is now read-only.
Improve exceptions handling #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ResourceLimitException
…xt() instead of checking InContext()
pinepain
force-pushed
the
require_context
branch
from
fa510f1 to
7d94fe6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves exceptions handling. It breaks few userland API, however, changes are trivial. For more details see change list below.
*Require Context explicitly inV8\Isolate::ThrowException();*RenameV8\Exceptions\GenericExceptiontoV8\Exceptions\Exception;*RenameV8\Exceptions\AbstractResourceLimitExceptiontoV8\Exceptions\ResourceLimitException;internal:Check whether returned context is empty inV8\Isolate\GetEnteredContext()instead of checkingInContext().*- BC-breaking or potentially BC-breaking changes