Skip to content

Conversation

@oallain
Copy link
Contributor

@oallain oallain commented May 28, 2019

Fix issue #63

Add new argument added in phpstan/phpstan-shim 0.11.8

See phpstan/phpstan@673d614#diff-82c59c19b209a1f51e4689b9f75b34d0R1831

@oallain
Copy link
Contributor Author

oallain commented May 28, 2019

cc @ondrejmirtes

@teohhanhui
Copy link

That looks like a BC break.

@ondrejmirtes ondrejmirtes merged commit 3c68697 into phpstan:master May 29, 2019
@ondrejmirtes
Copy link
Member

The mistake of phpstan-doctrine is using methods that are supposed to be internal. I will think about how to mitigate this in the future.

@oallain oallain deleted the fix/#63-missing-argument branch May 29, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants