Fix build method param types #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #481 +/- ##
============================================
- Coverage 96.62% 96.61% -0.01%
+ Complexity 2177 2176 -1
============================================
Files 66 66
Lines 5060 5058 -2
============================================
- Hits 4889 4887 -2
Misses 171 171
☔ View full report in Codecov by Sentry. |
williamdes
approved these changes
Jun 13, 2023
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
The code change looks okay
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
kamil-tekiela
force-pushed
the
Fix-build-param-types
branch
from
f69b6e6 to
bb7a7f6
Compare
MauricioFauth
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is broken polymorphism as the type breaks contravariance. Actually, this method seems to break every rule of OOP. So this is just a small bandaid over the larger issue, which requires a little bit more work.