fix #255: add missing options in SET statement #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## QA #276 +/- ##
=========================================
Coverage 99.62% 99.62%
Complexity 1860 1860
=========================================
Files 63 63
Lines 4523 4523
=========================================
Hits 4506 4506
Misses 17 17 |
williamdes
approved these changes
Dec 29, 2019
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
LGTM
Thank you so much for your work on this issue @devenbansod!
Member
|
And QA branch is the right target, the difference is just php support and some code changes |
williamdes
added a commit
that referenced
this pull request
Dec 31, 2019
Pull-request: #276 Fixes: #255 Signed-off-by: William Desportes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://dev.mysql.com/doc/refman/8.0/en/set-variable.html
Not sure if this should target the QA branch or the master branch since it changes a static field (which could be called a breaking change by some).
@MauricioFauth @williamdes what do you think?