Skip to content

Conversation

@MauricioFauth
Copy link
Member

Drop support for PHP 5.3, PHP 5.4, PHP 5.5, PHP 5.6, PHP 7.0 and HHVM

Since phpMyAdmin requires PHP 7.1, it makes sense to require PHP 7.1 for sql-parser as well.

Drop support for PHP 5.3, PHP 5.4, PHP 5.5, PHP 5.6, PHP 7.0 and HHVM

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth MauricioFauth merged commit 98a493a into phpmyadmin:master Jan 8, 2019
@MauricioFauth MauricioFauth deleted the php71 branch January 8, 2019 20:14
@MauricioFauth MauricioFauth self-assigned this Jan 8, 2019
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Jan 8, 2019
@remicollet
Copy link
Contributor

I think a v4 branch is needed... current phpMyAdmin (4.8.x) still rely on it

@ibennetch
Copy link
Member

Anyone who still uses the version 4 can pull it from the Git tag v4.3.1 or GitHub release 4.3.1, minimizing the importance of having the branch — but I think that creating the branch now will encourage fixes to be backported to v4 by authors, so I do think it's a good idea and will take care of it.

@ibennetch
Copy link
Member

We should decide on a name for the branch, though; I'm partial to v4 or version4...keeping with the phpMyAdmin style we might also prefer QA_4_3. Any opinions?

@MauricioFauth
Copy link
Member Author

@ibennetch What about 4.x? I also like v4.

@ibennetch
Copy link
Member

ibennetch commented Jan 19, 2019

Both of those are good ideas. Since no one has really offered any other suggestion I'm thinking 4.x is probably best. I'll make the branch from the release tag sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants