-
-
Notifications
You must be signed in to change notification settings - Fork 110
Throw a parse error if a comma missing between two alter operations #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
============================================
+ Coverage 99.75% 99.75% +<.01%
- Complexity 1736 1740 +4
============================================
Files 58 58
Lines 4147 4158 +11
============================================
+ Hits 4137 4148 +11
Misses 10 10 |
williamdes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
9b00223 to
ca22db7
Compare
|
@williamdes any idea why the |
williamdes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @devenbansod for the contribution !
Using the dropdown some tests seem to not cover the line, I do not know more 😕 |
|
@williamdes I do believe (actually made sure code is being executed by putting a print statement in code while running) tests are touching the code. Not sure why it's not been caught here. Anyway, I guess we can go ahead with merging this fix. I'll try to see if I can get it covered in some other PR maybe. Does it sound okay? |
|
@devenbansod Yes, go ahead, okay for me 👍 |
|
@williamdes it seems like it was just due to improper formatting. I moved the first condition of the elseif statement to previous line and now it's covering the entire diff. :-) |
Signed-off-by: Deven Bansod <[email protected]>
Fix #189
Signed-off-by: Deven Bansod [email protected]