Add support for end options in SET statement #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support `[{ COLLATE expr | DEFAULT }] in `SET NAMES` statement
Signed-off-by: Deven Bansod <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
============================================
+ Coverage 99.75% 99.75% +<.01%
- Complexity 1733 1736 +3
============================================
Files 58 58
Lines 4137 4147 +10
============================================
+ Hits 4127 4137 +10
Misses 10 10 |
williamdes
approved these changes
Dec 21, 2018
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
LGTM
Thank you for the contribution @devenbansod !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[{ COLLATE expr | DEFAULT }] inSET NAMES` statementFix #190
Signed-off-by: Deven Bansod [email protected]