Skip to content

Conversation

@devenbansod
Copy link
Member

Issue #204 seems to point a breakage in building of Create or Replace View. I did not find it, but thought if I could add a test, I would provide it as a reference to close the issue.

Signed-off-by: Deven Bansod [email protected]

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #209   +/-   ##
=========================================
  Coverage     99.75%   99.75%           
  Complexity     1717     1717           
=========================================
  Files            57       57           
  Lines          4094     4094           
=========================================
  Hits           4084     4084           
  Misses           10       10

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Is the build expected to succeed ?

@devenbansod
Copy link
Member Author

@williamdes thanks for the review.

At #204, it was reported that the building of the CREATE or REPLACE VIEW statement is broken, but I found it to be working correctly.

I decided to add this test so that I could demonstrate to the issue reporter that it indeed is working as expected.

So, with this PR (since the CI is green), we could close #204 saying it's working as expected (and requesting the author to re-open the issue if the library does misbehave while building some specific variant of CREATE or REPLACE VIEW)

@williamdes williamdes merged commit 688b7a6 into phpmyadmin:master Dec 20, 2018
@williamdes williamdes self-assigned this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants