Update title and descriptions for manual pages #1372
Merged
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of the new information that Phd will display once php/phd#201 is merged. It changes the title on the home page also to just "PHP" (removing the `: Hypertext Preprocessor` part). It also changes the meta information for manual pages, which is used for social media cards.
derickr
requested review from
saundefined,
sy-records and
sgolemon
as code owners
TimWolla
reviewed
Aug 28, 2025
include/layout.inc
Outdated
Comment on lines
429
to
430
| $meta_description = "PHP is a popular general-purpose scripting language that powers everything from your blog to the most popular websites in the world."; | ||
| $meta_description = $config['description'] ?? $title; |
There was a problem hiding this comment.
That doesn't seem right. We should not use the title if there is no description given.
There was a problem hiding this comment.
What would you like to see instead?
There was a problem hiding this comment.
The old generic description ("PHP is a popular general-purpose scripting language that powers everything from your blog to the most popular websites in the world.") would work (or just nothing).
|
🚀 Regression report for commit 3dbf1bf is at https://web-php-regression-report-pr-1372.preview.thephp.foundation |
|
🚀 Preview for commit 3dbf1bf can be found at https://web-php-pr-1372.preview.thephp.foundation |
sy-records
reviewed
Aug 29, 2025
sy-records
reviewed
Aug 29, 2025
sy-records
reviewed
Sep 3, 2025
TimWolla
approved these changes
Sep 3, 2025
sy-records
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the new information that Phd will display once php/phd#201 is merged.
It changes the title on the home page also to just "PHP" (removing the
: Hypertext Preprocessorpart).It also changes the meta information for manual pages, which is used for social media cards.