Skip to content

Improve error message of an engine fails to seed from the CSPRNG #9160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2022
Merged

Improve error message of an engine fails to seed from the CSPRNG #9160

merged 1 commit into from
Jul 30, 2022

Conversation

TimWolla
Copy link
Member

No description provided.

@TimWolla TimWolla requested a review from zeriyoshi July 26, 2022 17:35
zeriyoshi
zeriyoshi approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@zeriyoshi zeriyoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
There is no test (from my implementation), but this would be acceptable because it would be difficult to intentionally generate.

kocsismate
kocsismate reviewed Jul 27, 2022
View reviewed changes
@TimWolla TimWolla mentioned this pull request Jul 27, 2022
Merged
@TimWolla TimWolla requested a review from kocsismate July 30, 2022 09:23
@TimWolla TimWolla merged commit 5aca25a into php:master Jul 30, 2022
@TimWolla TimWolla deleted the random-seed-failure-message branch July 30, 2022 13:37
@TimWolla TimWolla mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@kocsismate kocsismate kocsismate approved these changes

@zeriyoshi zeriyoshi zeriyoshi approved these changes

Assignees
No one assigned
Labels
Extension: random
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimWolla @cmb69 @kocsismate @zeriyoshi