Review parameter names in ext/sysvmsg #6247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Oct 1, 2020
ext/sysvmsg/sysvmsg.stub.php
Outdated
| function msg_receive(SysvMessageQueue $queue, int $desiredmsgtype, &$msgtype, int $maxsize, mixed &$message, bool $unserialize = true, int $flags = 0, &$errorcode = null): bool {} | ||
| function msg_receive( | ||
| SysvMessageQueue $queue, | ||
| int $expected_message_type, |
There was a problem hiding this comment.
Would something including "filter" or "watch" be any better?
There was a problem hiding this comment.
I like the original $desired_message_type terminology :) Though $filter_message_type also seems reasonable.
There was a problem hiding this comment.
OK, I went with $desired_message_type. I don't like it too much (I wouldn't use the word "desire" in a professional context ^^ maybe it's just me...), but since I have no real better alternative, it'll be fine.
65 tasks
kocsismate
force-pushed
the
sysvmsg-name
branch
from
34f6c1d to
8b58496
Compare
nikic
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.