Update iconv names

[nikic]

I've renamed $charset to $encoding here, as we use this terminology in mbstring and also htmlspecialchars. iconv itself also has iconv_get/set_encoding. Though it also has input-charset and output-charset options in iconv_mime_encode.

[kocsismate]

Everything looks good to me.

I've renamed $charset to $encoding here, as we use this terminology in mbstring and also htmlspecialchars

I'm not a pro in this topic, but based on https://stackoverflow.com/questions/2281646/whats-the-difference-between-encoding-and-charset there is some difference between charset and encoding. So are the new usages still ok?

[nikic]

Everything looks good to me.

I've renamed $charset to $encoding here, as we use this terminology in mbstring and also htmlspecialchars

I'm not a pro in this topic, but based on https://stackoverflow.com/questions/2281646/whats-the-difference-between-encoding-and-charset there is some difference between charset and encoding. So are the new usages still ok?

Yes, iconv's usage is consistent with "encoding". Though in practice those words are really synonyms at this point :)