Skip to content

Fix BC break of zend_throw_exception #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix BC break of zend_throw_exception #5670

wants to merge 1 commit into from

Conversation

twose
Copy link
Member

@twose twose commented Jun 5, 2020 •
edited
Loading

carusogabriel
carusogabriel reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test that can be add to ensure this won't break?

@twose
Copy link
Member Author

twose commented Jun 6, 2020 •
edited
Loading

Is there any test that can be add to ensure this won't break?

I have added a test for it, it would lead to coredump without this patch

@php-pulls php-pulls closed this in cb22758 Jun 6, 2020
@twose twose deleted the patch-1 branch June 7, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

+1 more reviewer

@carusogabriel carusogabriel carusogabriel left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twose @nikic @carusogabriel