Fix compilation error on mac with -Wshift-negative-value #5284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
force-pushed
the
fix-jit-mac-compile
branch
from
8edbcde to
1122d7b
Compare
nikic
reviewed
Mar 22, 2020
Fix for mac OS build error seen in ccc49ea when shifting -1 (max argument count?) ``` ext/opcache/jit/zend_jit_trace.c:1668:2: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value] TRACE_FRAME_INIT(frame, op_array, 0, -1); ```
TysonAndre
force-pushed
the
fix-jit-mac-compile
branch
from
1122d7b to
687d57a
Compare
nikic
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for mac OS build error seen in ccc49ea
when shifting -1 (max argument count?)
EDIT: Should be
unsigned int, notuint, I've spent too much time with golang