Skip to content

typofixes - code related #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

typofixes - code related #395

wants to merge 12 commits into from

Conversation

vlajos
Copy link
Contributor

@vlajos vlajos commented Jul 23, 2013

typo fixes

@weltling
Copy link
Contributor

Whereby such fixes are nice, do you actually run the tests after them? Last time such fixes came in I could count at least 3 testfails. That's of course not bad, but costs time to figure out.

@vlajos
Copy link
Contributor Author

vlajos commented Aug 4, 2013

Not yet... I spent a half an hour to guess how I should, but I failed.
I have a debian sid system. The source says it doesn't support the installed bison version.

Could you please send me some instructions/url?

Thanks.

smalyshev
smalyshev reviewed Aug 4, 2013
View reviewed changes
ext/xml/expat_compat.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid since this is an externally accessible structure, we can not just change the name. At least we'd have to have aliased #define for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the solution in the next commit? (I couldn't test it...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this probably would work

@php-pulls
Copy link

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Aug 18, 2013
@dunglas dunglas mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vlajos @weltling @php-pulls @smalyshev