Fixed Bug #61025 __invoke() visibility not honored

[reeze]

See bug https://bugs.php.net/bug.php?id=61025

This patch make __invoke() visibility consist with other magic methods.

[lstrojny]

Don’t we miss a return 0 here?

[reeze]

Hmm, I only see four conditions, they are closure function and other three possible ZEND_ACC_PPP* flags.
or else it's common function, but that wouldn't happen when get the function with get_closure

[laruence]

I don't think this need to be fixed in this way, like __call:

<?php

class Bar {
    private function __call($name, $value) {
        return __CLASS__;
    }
}

$b = new Bar;
$b->__call("name", NULL);

works well, but with an warning:

Warning: The magic method __call() must have public visibility and cannot be static 

I am not sure whether this is a bug, or just need document.

[jpauli]

This patch is inconsistent with what actually exist.
Actually, __magics() signature are checked at compile time, not at run-time. This patch adds runtime checks for __invoke() , which IMO is wrong.

I think it's better to stay consistent and add the checks in the zend_compile.c cases.
Visibility is never checked at runtime for __magics() (but used to be).

[php-pulls]

Comment on behalf of laruence at php.net:

wrong fix, closed