Fix GH-20370: forbid user stream filters to violate typed property constraints

[alexandre-daubois]

Use zend_update_property() instead of doing things "manually".

[ndossche]

On a phone , so can't check. But you're looking at the property info now, however dynamic properties don't have any. So that means that a dynamically created property $stream would've been overwritten before this patch but now no longer. So that is an unintended behaviour change.

[alexandre-daubois]

Oh alright, I wasn't aware of this subtlety of dynamic properties. Let's refine that.

[bukka]

Hmm so that would require to someone create the dynamic property in filter first and it could then be used in subsequent calls for stream, right? If so, that sounds like a proper edge case... :)

[ndossche]

The easiest way to test this is to create a onCreate method that sets a dynamic property on $this

[ndossche]

This will work, except for a pre-existing bug:
When there is an unset or uninit typed property, but it is declared, its existence will be ignored.

It would also be great to try to avoid OBJPROP so that the property table isn't rebuilt, but that isn't critical.

[alexandre-daubois]

I tried to implement what you have in mind in 04e0955

[arnaud-lb]

This looks good to me!

Maybe @bukka or @ndossche want to take another look.

[ndossche]

Thanks for tackling this. As I said in the issue I opened, it's a bit of an annoying issue (as you have felt).

[alexandre-daubois]

Thanks @ndossche, I addressed your comments in the last commit

[ndossche]

See last nit, once that's resolved I think this can be approved.

[ndossche]

Thanks for tackling this annoying issue

[bukka]

It looks correct to me. We should probably introduce some nicer api for that fake_scope as it has not been used outside zend and reflection. It should not be directly accessed filters code IMHO but new API is more master material...

[ndossche]

Thanks. Go ahead.

[alexandre-daubois]

Thanks for your reviews!