ext/openssl: Deprecate $key_length parameter of openssl_pkey_derive() #19421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
reviewed
Aug 8, 2025
bukka
approved these changes
Aug 8, 2025
|
@bukka do you know why MacOS is seemingly segfaulting? |
bukka
reviewed
Aug 8, 2025
| -----END PUBLIC KEY----- | ||
| "); | ||
|
|
||
| var_dump(openssl_pkey_derive($pub, $priv, 10)); |
There was a problem hiding this comment.
Why do you expect this to be false?
It's not segfaulting but printing the derived secret. I added comment to the test as I'm not sure why there is that false check. This looks like copy of the |
|
Ah because it's lower for DH... |
|
Ah MacOS is still on 1.1.1 (which is good because we at least have some test for it) which actually segfaults for me too. |
|
This is a bug #19428 For testing this deprecation, just use for now. |
Girgias
force-pushed
the
8.5-openssl-dep
branch
from
c609660 to
eb5cea1
Compare
bukka
reviewed
Aug 9, 2025
| -----END PUBLIC KEY----- | ||
| "); | ||
|
|
||
| var_dump(bin2hex(openssl_pkey_derive($pub, $priv, 100))); |
There was a problem hiding this comment.
Suggested change
| var_dump(bin2hex(openssl_pkey_derive($pub, $priv, 100))); | |
| var_dump(bin2hex(openssl_pkey_derive($pub, $priv, 1000))); |
And update expectation,,,
Girgias
force-pushed
the
8.5-openssl-dep
branch
from
eb5cea1 to
78a69d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_key_length_parameter_of_openssl_pkey_derive