Skip to content

Use consistent type for h on call zend_hash_index_* #19255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marc-mabe
Copy link
Contributor

zend_hash_index_* expects zend_ulong for the h argument but often this argument got casted to zend_long (instead of zend_ulong.

Additionally, most of the time, a pointer first got casted to (uintptr_t) before (zend_ulong) but sometimes a pointer got casted directly. I noticed this during my work of #19079 as it fails if the pointer size and zend_ulong differs.

@devnexen
Copy link
Member

changes look correct to me cc @nielsdos

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are right, although also kinda not necessary at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants