Skip to content

fileinfo: Show libmagic version with . in PHPInfo output #18399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

fileinfo: Show libmagic version with . in PHPInfo output #18399

merged 1 commit into from
Apr 23, 2025

Conversation

TimWolla
Copy link
Member

This makes the output in PHPInfo a little more readable.

@TimWolla
fileinfo: Show libmagic version with . in PHPInfo output
46ec8bc 
This makes the output in PHPInfo a little more readable.
@TimWolla TimWolla requested a review from Girgias April 22, 2025 20:20
Girgias
Girgias approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM, would be nice to have a test for this but phpinfo tests are always a bit tricky

@TimWolla
Copy link
Member Author

but phpinfo tests are always a bit tricky

Yeah and the change is reasonably trivial and easy to verify manually.

@TimWolla TimWolla merged commit 00affe4 into php:master Apr 23, 2025
8 of 9 checks passed
@TimWolla TimWolla deleted the fileinfo-phpinfo-version branch April 23, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: fileinfo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimWolla @Girgias