Skip to content

Bug #62328 (implementing __toString and a cast to string fails) #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
php-pulls merged 2 commits into from
Aug 12, 2012
Merged

Bug #62328 (implementing __toString and a cast to string fails) #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5dfd41
zend_make_printable_zval choses cast_object over __toString
lt Aug 10, 2012
222ab9d
Test for bug 62328
lt Aug 10, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Zend/tests/bug62328.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
--TEST--
Bug #62328 (cast_object takes precedence over __toString)
--FILE--
<?php

class SplFileInfo62328 extends SplFileInfo
{
public function __toString()
{
return '__toString';
}
}

$fi = new SplFileInfo62328(__FILE__);

echo (string)$fi . PHP_EOL;
echo (string)$fi->__toString() . PHP_EOL;

?>
--EXPECT--
__toString
__toString
6 changes: 6 additions & 0 deletions Zend/zend.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,12 @@ ZEND_API void zend_make_printable_zval(zval *expr, zval *expr_copy, int *use_cop
{
TSRMLS_FETCH();

if (Z_OBJCE_P(expr)->__tostring) {
if (zend_std_cast_object_tostring(expr, expr_copy, IS_STRING TSRMLS_CC) == SUCCESS) {
break;
}
}

if (Z_OBJ_HANDLER_P(expr, cast_object)) {
zval *val;

Expand Down