ext/pcre: update to PCRE2 v10.44 #14498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
approved these changes
Jun 7, 2024
ndossche
requested changes
Jun 7, 2024
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Thanks, the only thing that's missing is the change in the pcre2.h header to include pcre2_set_max_pattern_compiled_length. See the diff of pcre2.h.{in,generic}
Ayesh
force-pushed
the
pcre2-1044
branch
2 times, most recently
from
a7f2057 to
106b387
Compare
Member
Author
|
Thank you for catching it @nielsdos. I merged changes from from upstream |
Previously: phpGH-13413. This version also contains a fix with `preg_match('\X')`, so that it can correctly detect grapheme clusters (PCRE2Project/pcre2#410). This is useful to correctly [polyfill the new `grapheme_str_split` function](https://php.watch/versions/8.4/grapheme_str_split#polyfill). Diff: pcre2lib [v10.43..v10.44](PCRE2Project/pcre2@pcre2-10.43...pcre2-10.44)
Member
Author
|
Thank you! |
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Jun 8, 2024
In phpGH-14498, we updated pcre2lib to v10.44. However, it missed syncing the config, that changes upstream `MAX_NAME_SIZE` from 32 to 128. Ref: [1](PCRE2Project/pcre2@ced3b0f#diff-91c5b46dc84a94604a4e4d0caed9bf85590a2eddbb12d2e8dc80badf324a9dfb), [2](PCRE2Project/pcre2@6c670c7)
ndossche
pushed a commit
that referenced
this pull request
Jun 8, 2024
In GH-14498, we updated pcre2lib to v10.44. However, it missed syncing the config, that changes upstream `MAX_NAME_SIZE` from 32 to 128. Ref: [1](PCRE2Project/pcre2@ced3b0f#diff-91c5b46dc84a94604a4e4d0caed9bf85590a2eddbb12d2e8dc80badf324a9dfb), [2](PCRE2Project/pcre2@6c670c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: GH-13413.
This version also contains a fix with
preg_match('\X'), so that it can correctly detect grapheme clusters (PCRE2Project/pcre2#410). This is useful to correctly polyfill the newgrapheme_str_splitfunction.Diff: pcre2lib v10.43..v10.44