refactor: change zend_is_true to return bool
#14301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
force-pushed
the
zend_is_true_returns_bool
branch
from
e92dbc9 to
335b74c
Compare
Previously this returned `int`. Many function actually take advantage
of the fact this returns exactly 0 or 1. For instance,
`main/streams/xp_socket.c` does:
sockopts |= STREAM_SOCKOP_IPV6_V6ONLY_ENABLED * zend_is_true(tmpzval);
And `Zend/zend_compile.c` does:
child = &ast->child[2 - zend_is_true(zend_ast_get_zval(ast->child[0]))];
I changed a few places trivially from `int` to `bool`, but there are
still many places such as the object handlers which return `int` that
should eventually be `bool`.
morrisonlevi
force-pushed
the
zend_is_true_returns_bool
branch
from
335b74c to
64281bd
Compare
Contributor
Author
|
The failed Travis tests occur on |
morrisonlevi
requested review from
Girgias,
SakiTakamachi,
bukka,
dstogov,
iluuu1994 and
ndossche
as code owners
dstogov
reviewed
May 23, 2024
Member
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
I don't care about this kind of changes.
A quick code-review didn't show any problems.
Member
|
Ok for DOM and XSL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this returned
int. Many function actually take advantage of the fact this returns exactly 0 or 1. For instance,main/streams/xp_socket.cdoes:And
Zend/zend_compile.cdoes:I changed a few places trivially from
inttobool, but there are still many places such as the object handlers which returnintthat should eventually bebool.I'm not quite sure yet what to do with
ext/opcache/jit/zend_jit_ir.c:What I understand from
IR_BOOLand such so far, is that this is probably correct forboolreturns already, but it's worth mentioning for people more expert than I am to comment on.