Enable pdo-firebird nightly testing
#12699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the
pdo-firebirdtest provided in #12677 for nightly testing.The solution is the same.
nightly.ymlusestest-linux/action.ymlin the same way aspush.ymlto execute the test, so i created a firebird service container for all Jobs that reference the test action.NoteEven after merging this pull request, some tests fail innightly.yml. There are tests that are fine inpush.ymlbut fail only innightly.yml. You can see the results in my repository:https://github.com/KentarouTakeda/php-src/actions/runs/6901762828/job/18777809789#step:12:151We plan to create another pull request to resolve this issue.UPDATE: 2023-11-17 23:29 JST
I also fixed a potential test fail exposed by running
nightly.ymlAvoid memory leak report
Firebird's client library seems to have a memory leak issue. Most of the tests had the report suppressed, but there were two that were not specified and caused the test to fail. I fixed it. At that time, i unified the way to write suppression settings.
The memory leak problem was reported to Firebird by @SakiTakamachi with FirebirdSQL/firebird#7849 . If this is fixed, we should be able to unsuppress the report as well.
Memory alignment issue
There was a potential memory alignment violation when retrieving
floatvalues from the client library. I fixed it the same way as 21e0305.