Use Clang 16 to work around LSAN TLS crashes #12496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Oct 22, 2023
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM, can we use the same approach for nightly with GCC? I'm not sure if older versions of GCC work with newer versions of libasan. I'd also be ok with switching to Clang on nightly, however the JIT is currently incompatible with UBSAN on Clang.
Member
Author
Via a ppa yes. Do we actually run into this, or is the version used with gcc recent enough to not have the issue? |
Member
|
@nielsdos I'm not sure. There have been crashes due to |
iluuu1994
pushed a commit
to iluuu1994/php-src
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun out from #12111