Skip to content

Fix comment for php_safe_bcmp #10306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 2 commits into from
Jan 12, 2023
Merged

Fix comment for php_safe_bcmp #10306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e29d44a
main: Fix comment for php_safe_bcmp
TimWolla Jan 12, 2023
5ee5603
main: Include note about php_safe_bcmp being security sensitive
TimWolla Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion main/safe_bcmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include <string.h>

/*
* Returns 0 if both inputs match, 1 if they don't.
* Returns 0 if both inputs match, non-zero if they don't.
* Returns -1 early if inputs do not have the same lengths.
*
*/
Expand All @@ -34,6 +34,7 @@ PHPAPI int php_safe_bcmp(const zend_string *a, const zend_string *b)
return -1;
}

/* This is security sensitive code. Do not optimize this for speed. */
while (i < ZSTR_LEN(a)) {
r |= ua[i] ^ ub[i];
++i;
Expand Down