Generate methodsynopses from stubs for ext/intl (IntlCalendar) #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Oct 8, 2021
| &reftitle.returnvalues; | ||
| <para> | ||
| An ICU error code indicating either success, failure or a warning. | ||
| An ICU error code indicating either success, failure or a warning. Returns &false; on failure. |
There was a problem hiding this comment.
Suggested change
| An ICU error code indicating either success, failure or a warning. Returns &false; on failure. | |
| An ICU error code indicating either success, failure or a warning. Returns &false; when there is no error to fetch. |
Or something similar?
There was a problem hiding this comment.
Is it true actually?
/* Fetch the object (without resetting its last error code ). */
co = Z_INTL_CALENDAR_P(object);
if (co == NULL)
RETURN_FALSE;
So it returns false when the Calendar_object cannot be retrieved, doesn't it?
There was a problem hiding this comment.
Right, well I would have expected this to throw an Error but oh well. (actually maybe we need to check what the macro does)
There was a problem hiding this comment.
Checked it :) It returns the struct
Girgias
reviewed
Oct 9, 2021
|
Has the last commit addressed your comments, right? Can I merge it? |
Girgias
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.