Skip to content

Conversation

@rvanlaak
Copy link
Member

@rvanlaak rvanlaak commented Jan 2, 2020

... and use branch alias if available via minimum-req = dev.

@odolbeau
Copy link
Member

odolbeau commented Jan 2, 2020

Linked to #367
See also #374 (comment)

@Nyholm WDYT?

path: Twig/TranslationExtension.php

-
message: "#^Call to method getValue\\(\\) on an unknown class Symfony\\\\Component\\\\Translation\\\\DataCollector\\\\Data\\.$#"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed with stable version of symfony/translation

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you.

I've min-stabillity causes more issues, lets remove it =)

@Nyholm Nyholm merged commit 151f3db into php-translation:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants