Improve download command #369
Conversation
| ) | ||
| ->addArgument('configuration', InputArgument::OPTIONAL, 'The configuration to use', 'default') | ||
| ->addOption('cache', null, InputOption::VALUE_NONE, 'Clear the cache if the translations have changed') | ||
| ->addOption('cache', null, InputOption::VALUE_NONE, '[DEPRECATED] Cache is now automatically cleared when translations have changed.') |
Command/DownloadCommand.php
Outdated
| if ($input->getOption('cache')) { | ||
| $message = 'The --cache option is deprecated as it\'s now the default behaviour of this command.'; | ||
|
|
||
| $io->error($message); |
There was a problem hiding this comment.
Is it relevant to display an error or is the trigger_error call enough?
There was a problem hiding this comment.
Good question, especially as it's on CLI.
Maybe use note? To be sure return code isn't affected?
https://symfony.com/doc/current/console/style.html#admonition-methods
There was a problem hiding this comment.
The return code is never affected by what you display in the CLI. :)
With a note:
Wit a caution:
With an error:
My question was: should we display something in the cli regarding the deprecated option or is the trigger_error call enough?
I used a note as suggested cause it's less "violent" than a caution or an error but we still have the information directly in the cli which is relevant IMO.
odolbeau
force-pushed
the
improve-download-command
branch
from
da2c93a to
46e2754
Compare
Command/DownloadCommand.php
Outdated
| if ($input->getOption('cache')) { | ||
| $message = 'The --cache option is deprecated as it\'s now the default behaviour of this command.'; | ||
|
|
||
| $io->error($message); |
There was a problem hiding this comment.
Good question, especially as it's on CLI.
Maybe use note? To be sure return code isn't affected?
https://symfony.com/doc/current/console/style.html#admonition-methods
odolbeau
force-pushed
the
improve-download-command
branch
from
46e2754 to
eaf8af4
Compare
3 participants
Fix #111