Skip to content

Conversation

@odolbeau
Copy link
Member

@odolbeau odolbeau commented Dec 4, 2018

@rvanlaak
Copy link
Member

rvanlaak commented Dec 5, 2018

Tests are failing, but I see the test graph is quite big.

@Nyholm what about bumping to Symfony LTS 3.4 and PHP 7.2?

https://symfony.com/roadmap

That might also be a nice moment to put effort in a v1.0 release.

#252

https://github.com/php-translation/symfony-bundle/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+milestone%3A%22Version+1.0%22

@odolbeau
Copy link
Member Author

odolbeau commented Dec 5, 2018

Tests were failing before this PR, I just removed some deprecation notices. I'll rebase this PR once master will be green if needed.

I'm not sure this PR should be linked to a symfony / PHP version bumping or a coming major release as it's not impacted nor impacting those changes.

Anyway I can propose another PR to bump requirements to "php":"^7.2" & "symfony/*": "^3.4 || ^4.0" if you want?

@Nyholm
Copy link
Member

Nyholm commented Dec 27, 2018

Hm. Yeah, maybe it is a good idea do use sf3.4 as minimum.

This PR looks good, (even though tests are failing).
Thank you.

@Nyholm Nyholm merged commit 29b83ef into php-translation:master Dec 27, 2018
@mpiot mpiot mentioned this pull request Mar 7, 2019
@odolbeau odolbeau deleted the avoid-deprecated-calls branch April 12, 2019 06:28
@XWB
Copy link
Contributor

XWB commented May 3, 2019

@Nyholm Can you tag a new release that contains this change?

@hvt
Copy link

hvt commented Jul 12, 2019

Would indeed be great if a new release could be tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants