Get rid of bootstrap overrides #230
Conversation
| </head> | ||
| <body> | ||
|
|
||
| <nav class="navbar navbar-light bg-faded"> |
There was a problem hiding this comment.
Hm, it may be that devs already have configs ID somewhere in their template. I'd rather use CSS class here too like:
<nav class="configs navbar navbar-light bg-faded">
Possible CSS classes duplicating is much better than ID duplicating IMO
There was a problem hiding this comment.
Agree, will fix this this evening
| #configs { | ||
| padding: 0 2rem; | ||
| } | ||
| .navbar-nav .nav-text{ |
There was a problem hiding this comment.
And actually it won't work :) I suppose it should be:
#configs.navbar-nav .nav-text {
i.e. there should be no space between #configs and .navbar-nav since we're talking about the same tag
There was a problem hiding this comment.
No, there is navbar > navbar-nav
See https://github.com/php-translation/symfony-bundle/blob/master/Resources/views/WebUI/base.html.twig#L14
| width: 6rem; | ||
| } | ||
|
|
||
| .navbar-nav .nav-link { |
3 participants
If I change the layout to integrate another one, I have some css overrides in webui.css. This remove bootstrap overrides for navbar