Concatenated labels #127
Merged
Concatenated labels #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests are deprecation notices, and are not due to this PR. |
bocharsky-bw
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Looks good to me 👍
IMO it's a bad practice to split the translation key with a few concatenated parts... but as we see from the issue I created it may happen if you use a long real message instead of key and want to avoid a really long line. Thank you for fixing this edge case!
welcoMattic
approved these changes
Feb 7, 2022
|
Thank you for this feature, @Stadly ! And sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for concatenated translation labels.
Fixes #125.