Allow to set Custom namespace for commands, also #919
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow to set custom array as CommandPath to prevent vendors commands and define your own commands outside vendor
vdavari
approved these changes
Jan 29, 2019
ImanX
approved these changes
Jan 30, 2019
noplanman
reviewed
Feb 1, 2019
| */ | ||
| public function setCommandsPath(array $paths) | ||
| { | ||
| $this->commands_paths = $paths; |
There was a problem hiding this comment.
@imami Best to set as an empty array and then use the existing addCommandsPaths method to add paths. Just to ensure the reuse of code.
noplanman
reviewed
Feb 1, 2019
| @@ -277,7 +298,7 @@ public function getCommandObject($command) | |||
| $which[] = 'User'; | |||
|
|
|||
| foreach ($which as $auth) { | |||
| $command_namespace = __NAMESPACE__ . '\\Commands\\' . $auth . 'Commands\\' . $this->ucfirstUnicode($command) . 'Command'; | |||
| $command_namespace = $this->commands_namespace . $auth . 'Commands\\' . $this->ucfirstUnicode($command) . 'Command'; | |||
There was a problem hiding this comment.
I'd vote for having this as $this->commands_namespace . '\\' . $auth . 'Commands\\', to not require the final backslashes when setting the namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
setCommandsNamespace()andsetCommandsPath()methods to prevent vendors commands and define your own commands outside vendor. before to these changes, you must override vendor's commands likeStartCommandwith the same namespace, wich might cause PHP exception of class redeclaration.