-
-
Notifications
You must be signed in to change notification settings - Fork 964
issue #323 modify getCommandObject and executeCommand for possibility… #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #323 modify getCommandObject and executeCommand for possibility… #689
Conversation
… for possibility to use custom namespaces in commands
Please merge this feature. |
@Jonybang, looks interesting. But I think all we need is just to use PSR-4. |
Any chance that this will ever be integrated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged the latest develop branch and fixed up some bits of code.
Should be good to go now 🎉
@Jonybang and all others here, please excuse my delay on this, just wasn't sure about how the future of the commands system will look like. So until there is a clearer view, this is a great addition, thanks so much! |
3 years delay, not a big deal though 😁 |
I know, so so sorry 🙈 Then we can get this merged and I'll release the next version. |
sorry, since the last year i haven't my php environment, but if you can run two bots in the same time with this code - everything is okay 😊 |
Yes please! Do you mean running two bots in parallel, or using the same code but a different config for each bot? |
In my laravel api routes i've defined two POST routes:
Commands of Bot1 i've stored in |
@Jonybang Right, thanks. That will still work without problems 👍 |
For issue: Mess with custom command loading (#323)
Was add possibility to use custom namespace for commands. The code is tested on a real project and works well with two parallel bots. Also backward compatibility is observed